Hi Arnd, Thanks for your review. > From: linux-wireless-owner@xxxxxxxxxxxxxxx [mailto:linux-wireless- > owner@xxxxxxxxxxxxxxx] On Behalf Of Arnd Bergmann > Sent: Monday, February 08, 2016 5:40 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Nishant Sarmukadam; > wnhuang@xxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Xinming Hu > Subject: Re: [PATCH v3 1/3] mwifiex: register platform specific driver > > On Monday 08 February 2016 02:15:26 Amitkumar Karwar wrote: > > diff --git a/Documentation/devicetree/bindings/mwifiex.txt > > b/Documentation/devicetree/bindings/mwifiex.txt > > new file mode 100644 > > index 0000000..39b6a74 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mwifiex.txt > > @@ -0,0 +1,29 @@ > > +mwifiex > > +------ > > + > > +Required properties: > > + > > + - name : must be "mwifiex" > > This is a very unusual requirement. > > Can you use one of the standard device names instead? > We will make use of marvell-sd8xxx in updated version as per Rob Herring's suggestions. It includes vendor name and a chipset/device name. > > + - compatible : must be "marvell,mwifiex" > > + > > +Optional properties: > > + > > + - mwifiex,caldata* : A series of properties with marvell,caldata > prefix, > > + represent Calibration data downloaded to the > device during > > + initialization. This is an array of unsigned > values. > > + > > + > > +Example: > > + > > +Tx power limit calibration data is configured in below example. > > +The calibration data is an array of unsigned values, the length can > > +vary between hw versions. > > + > > +mwifiex { > > + compatible = "marvell,mwifiex"; > > + > > + mwifiex,caldata_00_txpwrlimit_2g_cfg_set = /bits/ 8 < > > +0x01 0x00 0x06 0x00 0x08 0x02 0x89 0x01 ...>; > > + > > +}; > > Should we list the mac-address here as well, or is there always an > eeprom for that but not the calibration data? Yes. we do get MAC address along with other info from EEPROM. Regards, Amitkumar Karwar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
