Hi Boris, 2016-02-04 14:33 GMT+01:00 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>: > Hi Romain, > > Just a remark that is not directly related to your work: when people > take the time to review your work, try to keep them in Cc of the > following versions of your patchset. > OK. I'll keep it in mind for my next submission. > On Mon, 1 Feb 2016 11:25:55 +0100 > Romain Izard <romain.izard.pro@xxxxxxxxx> wrote: > >> The NAND Flash controller for SAMA5D2 has small differences that make it >> impossible to use the existing driver for SAMA5D3. This patchset uses the >> device tree's compatible string to get those differences, and the code is >> slightly modified to handle them. >> >> Base on linux-mtd-next, commit 15c0be7bec002f9a529dd0966d0db96dde176fd0 >> >> See previous revisions to apply on the Atmel Linux 4.1 branch. >> >> Compile tested for sama5_defconfig, and tested on SAMA5D3xek as there is no >> existing SAMA5D2 board with NAND Flash memory (yet). > > Overall, it looks good to me (even if I don't fully agree on how you > decided to define NFC_SR_RB_EDGEX values :-P, but that's just a > nitpick). > > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > Thanks for your review. Best regards, -- Romain Izard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
