> -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: 2016年2月4日 1:48 > To: Yang, Wenyou <Wenyou.Yang@xxxxxxxxx> > Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxx>; Liam Girdwood > <lgirdwood@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Pawel Moll > <pawel.moll@xxxxxxx>; Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>; Kumar > Gala <galak@xxxxxxxxxxxxxx>; Krzysztof Kozlowski > <k.kozlowski@xxxxxxxxxxx>; Lee Jones <lee.jones@xxxxxxxxxx>; Peter > Korsgaard <jacmet@xxxxxxxxx>; Ferre, Nicolas <Nicolas.FERRE@xxxxxxxxx>; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for > ACT8945A > > On Wed, Feb 03, 2016 at 02:33:11AM +0000, Yang, Wenyou wrote: > > > > I would just remove the "active-semi,act8945a-regulator" node and > > > make "active- semi,vsel-high" a property of the "active-semi,act8945a" node. > > > That way you can remove the mfd cell .of_compatible and OF table in > > > the regulator driver and read the "active-semi,vsel-high" using the > > > platform device's parent of_node. > > > > But it's better if you wait for Mark's opinions before re-spining your patches. > > > Hi Mark, what is your opinions? > > Like Javier says you should make your DT binding look like the DT bindings for > other MFDs and not use of_compatible. All right. Thank you, Mark, Javier. Best Regards, Wenyou Yang ?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
