Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




fu.wei@xxxxxxxxxx wrote:
+#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC
+static bool panic_enabled = true;

I think this should default to 'false', because IMHO, this seems like an odd feature. I'm not crazy about the fact that there's a Kconfig option for it either, but I'm not going to NACK this patch.

I personally would prefer to drop this patch, and just wait for full-blown pre-timeout support. It feels like a debugging feature that doesn't really belong upstream. But like I said, it's just my opinion, and I won't complain if I'm outvoted.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux