On Wednesday 03 February 2016 16:02:38 Lubomir Rintel wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> This takes the MAC address for smsc75xx/smsc95xx USB network devices
> from a the device tree. This is required to get a usable persistent
> address on the popular beagleboard, whose hardware designers
> accidentally forgot that an ethernet device really requires an a
> MAC address to be functional.
>
> The smsc75xx and smsc95xx drivers are just two copies of the
> same code, so better fix both.
>
> Tested-by: Lubomir Rintel <lkundrak@xxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
I have no memory of writing this patch, where did you find it?
The changelog sounds like I wrote it, so I assume it was me after all.
> + address = of_get_property(dev->udev->dev.of_node,
> + "local-mac-address", NULL);
> + if (address) {
> + memcpy(dev->net->dev_addr, address, ETH_ALEN);
> + return;
> + }
This should use of_get_mac_address(), not an open-coded property
lookup. The function was probably added after I wrote the
the original patch.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
