On 1 February 2016 at 23:10, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Sat, Jan 30, 2016 at 04:54:26PM +0800, Xinliang Liu wrote:
>> Add ADE display controller binding doc.
>> Add DesignWare DSI Host Controller v1.20a binding doc.
>>
>> Signed-off-by: Xinliang Liu <xinliang.liu@xxxxxxxxxx>
>>
>> v3:
>> - Make ade as the drm master node.
>> - Use assigned-clocks to set clock rate.
>> - Use ports to connect display relavant nodes.
>> v2:
>> - Move dt binding docs to bindings/display/hisilicon directory.
>
> Looks pretty good, just a few minor things.
>
Thanks for all your help.
>> ---
>> .../bindings/display/hisilicon/dw-dsi.txt | 60 ++++++++++++++++++++++
>> .../bindings/display/hisilicon/hisi-ade.txt | 56 ++++++++++++++++++++
>> 2 files changed, 116 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt
>> create mode 100644 Documentation/devicetree/bindings/display/hisilicon/hisi-ade.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt b/Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt
>> new file mode 100644
>> index 000000000000..44b945a54f3f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt
>> @@ -0,0 +1,60 @@
>> +Device-Tree bindings for DesignWare DSI Host Controller v1.20a driver
>> +
>> +A DSI Host Controller resides in the middle of display controller and external
>> +HDMI converter.
>> +
>> +Required properties:
>> +- compatible: value should be "hisilicon,hi6220-dsi".
>> +- reg: physical base address and length of the controller's registers.
>> +- clocks: the clocks needed.
>> +- clock-names: the name of the clocks.
>> +- ports: contains DSI controller input and output sub port. The input port
>> + connects to ADE output port, and output port connected to external HDMI
>
> or panel or any other bridge.
Right, I plan to support panel soon.
will change to:
s/output port connected to external HDMI/output port connected to
panel or any other bridge/
>
>> + endpoint. See Documentation/devicetree/bindings/graph.txt for more device
>> + graph info.
>> +
>> +A example of HiKey board hi6220 SoC and board specific DT entry:
>> +Example:
>> +
>> +SoC specific:
>> + dsi: dsi@0xf4107800 {
>
> Drop the '0x'
OK, will change to:
dsi: dsi@f4107800
>
>> + compatible = "hisilicon,hi6220-dsi";
>> + reg = <0x0 0xf4107800 0x0 0x100>;
>> + clocks = <&media_ctrl HI6220_DSI_PCLK>;
>> + clock-names = "pclk_dsi";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + dsi_in: endpoint {
>> + remote-endpoint = <&ade_out>;
>
> Indentation is wrong.
>
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>; /* 1 for output port */
>> + dsi_out: endpoint {
>> + remote-endpoint = <&adv7533_in>;
>
> ditto.
All the indentation will be fixed in v4.
>
>> + };
>> + };
>> + };
>> + };
>> +
>> +Board specific:
>> + i2c2: i2c@f7102000 {
>> + ...
>> +
>> + adv7533: adv7533@39 {
>> + ...
>> +
>> + port {
>> + adv7533_in: endpoint {
>> + remote-endpoint = <&dsi_out>;
>> + };
>> + };
>> + };
>> + };
>> +
>> diff --git a/Documentation/devicetree/bindings/display/hisilicon/hisi-ade.txt b/Documentation/devicetree/bindings/display/hisilicon/hisi-ade.txt
>> new file mode 100644
>> index 000000000000..47925826536c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/hisilicon/hisi-ade.txt
>> @@ -0,0 +1,56 @@
>> +Device-Tree bindings for hisilicon ADE display controller driver
>> +
>> +ADE (Advanced Display Engine) is the display controller which grab image
>> +data from memory, do composition, do post image processing, generate RGB
>> +timing stream and transfer to DSI.
>> +
>> +Required properties:
>> +- compatible: value should be "hisilicon,hi6220-ade".
>> +- reg: physical base address and length of the controller's registers.
>
> I see 3 ranges in the example. Please specify what each one is here.
will change to:
- reg: physical base address and length of the controller's registers.
Three reg ranges are used in ADE driver:
ADE reg range, value should be <0x0 0xf4100000 0x0 0x7800>;
media subsystem reg range, value should be <0x0 0xf4410000 0x0 0x1000>;
media subsystem NOC QoS reg range, value should be <0x0 0xf4520000 0x0 0x1000>;
>
>> +- reg-names: name of physical base.
>> +- interrupt: the interrupt number.
>> +- clocks: the clocks needed.
>
> Same here. Specify what the clocks are.
>
will change to:
- clocks: the clocks needed.
Three clocks are used in ADE driver:
ADE core clock, value should be <&media_ctrl HI6220_ADE_CORE>;
ADE pixel clok, value should be <&media_ctrl HI6220_ADE_PIX_SRC>;
media NOC QoS clock, value should be <&media_ctrl HI6220_CODEC_JPEG>;
- assigned-clock-rates: clock rates which are assigned to assigned-clocks.
The rate of <&media_ctrl HI6220_ADE_CORE> could be 360000000 or 180000000.
The rate of <&media_ctrl HI6220_CODEC_JPEG> could be less than 1440000000.
>> +- clock-names: the name of the clocks.
>> +- assigned-clocks: clocks to be assigned rate.
>> +- assigned-clock-rates: clock rates which are assigned to assigned-clocks.
>> +- port: the output port. This contains one endpoint subnode, with its
>> + remote-endpoint set to the phandle of the connected DSI endpoint.
>> + See Documentation/devicetree/bindings/graph.txt for more device graph info.
>> +
>> +Optional properties:
>> +- dma-coherent: Present if dma operations are coherent.
>> +
>> +
>> +A example of HiKey board hi6220 SoC specific DT entry:
>> +Example:
>> +
>> + ade: ade@f4100000 {
>> + compatible = "hisilicon,hi6220-ade";
>> + reg = <0x0 0xf4100000 0x0 0x7800>,
>> + <0x0 0xf4410000 0x0 0x1000>,
>> + <0x0 0xf4520000 0x0 0x1000>;
>> + reg-names = "ade_base",
>> + "media_base",
>> + "media_noc_base";
>> +
>> + interrupts = <0 115 4>; /* ldi interrupt */
>> +
>> + clocks = <&media_ctrl HI6220_ADE_CORE>,
>> + <&media_ctrl HI6220_CODEC_JPEG>,
>> + <&media_ctrl HI6220_ADE_PIX_SRC>;
>> + /*clock name*/
>> + clock-names = "clk_ade_core",
>> + "clk_codec_jpeg",
>> + "clk_ade_pix";
>> +
>> + assigned-clocks = <&media_ctrl HI6220_ADE_CORE>,
>> + <&media_ctrl HI6220_CODEC_JPEG>;
>> + assigned-clock-rates = <360000000>, <288000000>;
>> + dma-coherent;
>> +
>> + port {
>> + ade_out: endpoint {
>> + remote-endpoint = <&dsi_in>;
>> + };
>> + };
>> + };
>> --
>> 1.9.1
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
