From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> --- drivers/gpio/gpio-davinci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 84be701..7230c43 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) } clk = devm_clk_get(dev, "gpio"); - if (IS_ERR(clk)) { - printk(KERN_ERR "Error %ld getting gpio clock?\n", - PTR_ERR(clk)); + if (IS_ERR(clk)) return PTR_ERR(clk); - } + clk_prepare_enable(clk); /* -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html