Hello,
Some time ago I sent a v1 of this, now after testing the changes more
deeply patch 3 changed a bit. The old series started with
Date: Wed, 2 Dec 2015 11:07:11 +0100
From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Subject: [PATCH RFC 0/3] input: rotary_encoder: use more than two gpios as input
Message-Id: <1449050834-31779-1-git-send-email-u.kleine-koenig@xxxxxxxxxxxxxx>
The two first patches are just preparation for the third patch.
There is an obvious improvement that allows detection of quick changes
more reliably with >2 gpios, but I didn't implement this yet. (With 4
GPIOs you can distinguish a counter clockwise movement of three states
from a clock wise movement of a single state. Still the patch is useful
as it makes these devices work at all.
My test device looks as follows:
rotary@0 {
compatible = "rotary-encoder";
gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>, <&gpio4 11 GPIO_ACTIVE_HIGH>, <&gpio4 10 GPIO_ACTIVE_HIGH>, <&gpio4 9 GPIO_ACTIVE_HIGH>;
rotary-encoder,steps = <16>;
rotary-encoder,steps-per-period = <16>;
};
While Daniel Mack and Rojhalat Ibrahim agreed that this device is an
absolute encoder and should be supported by a simpler logic, I still
consider it worthwhile to get these patches in as a first step. Also the
binding looks right, so IMHO the comments shouldn't stop this series
from going in.
Best regards
Uwe
Uwe Kleine-König (3):
Input: rotary-encoder - make use of devm_* to simplify .probe and
.remove
Input: rotary-encoder - move configuration data to driver data
Input: rotary-encoder - support more than 2 gpios as input
.../devicetree/bindings/input/rotary-encoder.txt | 2 +-
arch/arm/mach-pxa/raumfeld.c | 25 +-
drivers/input/misc/rotary_encoder.c | 327 +++++++++------------
include/linux/rotary_encoder.h | 4 -
4 files changed, 158 insertions(+), 200 deletions(-)
--
2.7.0.rc3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
