Re: [PATCH v2 1/3] ata: Remove the AHCI_HFLAG_EDGE_IRQ support from libahci.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sun, Jan 31, 2016 at 3:32 AM, Tejun Heo <htejun@xxxxxxxxx> wrote:
> On Wed, Jan 27, 2016 at 03:19:55PM +0530, Suman Tripathi wrote:
>> This patch removes the AHCI_HFLAG_EDGE_IRQ support from libahci.
>> The upcoming patches will have the flexibility to override
>> irq handlers in the LLD's. Controller's implementing a EDGE trigger
>> latch can implement their own interrupt handler inside the driver.
>>
>> Signed-off-by: Suman Tripathi <stripathi@xxxxxxx>
>
> Shouldn't this patch come after the irq override is in place?
>
> 1. introduce irq override.
>
> 2. remove AHCI_HFLAG_EDGE_IRQ by moving the edge triggered handler to
>    ahci_xgene.
>
> 3. Update xgene irq handler to address the erratum.

Thought of remove the AHCI_HFLAG_EDGE entirely first because we don't
require it . Then implement the irq override capability.
>
> Thanks.
>
> --
> tejun



-- 
Thanks,
with regards,
Suman Tripathi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux