RE: [PATCH] ARM: dts: porter: add MAX3355 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

> From: Sergei Shtylyov
> Sent: Saturday, January 30, 2016 5:50 AM
> 
> On 01/29/2016 11:28 PM, Sergei Shtylyov wrote:
> 
> >>> From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx
> >>> [mailto:linux-renesas-soc-owner@xxxxxxxxxxxxxxx] On Behalf Of Sergei
> >>> Shtylyov
> >>> Sent: Wednesday, January 27, 2016 7:14 AM
> >>>
> >>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings
> >>> are upstream along with the 'extcon' hook  in the Renesas USBHS driver, we
> >>> can add  MAX3355 device node to  the Porter device tree and properly refer
> >>> to it from the USBHS node instead of using  "renesas,enable-gpio" property
> >>> which only allowed checking the USB ID pin  at the driver probe time;  now
> >>> this  pin's  state can be monitored dynamically!
> >>>
> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >>
> >> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened
> >> even if I connected/disconnected a usb convert cable (usb micro-ab to A).
> >> Remarks: I confirmed that the usb convert cable worked correctly on other
> >> board.
> >
> >     I guess I have the same cable
> 
>     No, I have mini-AB connector here and hence my cable is mini-AB to A.

I checked Porter specification and then I found 2 specifications exist...
 Porter "B" : mini AB connecter and Max3355 is on the board.
 Porter "C" : micro AB connect and Max3355 is not on the board. (Select host/peripheral by a jumper.)

I guess that your current target is "B".
If so, I think this patch is acceptable.

Best regards,
Yoshihiro Shimoda

> > and IRQs do happen for me when I connect and
> > disconnect it (as it should be).
> 
> >> Best regards,
> >> Yoshihiro Shimoda
> 
> MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux