On Mon, 25 Jan 2016 23:46:30 +0100 Alban <albeu@xxxxxxx> wrote: > On Sat, 23 Jan 2016 23:17:25 +0300 > Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote: > > > This patch introduces devicetree for Atheros AR9331 SoC (AKA Hornet). > > The AR9331 chip is a Wi-Fi System-On-Chip (WiSOC), > > typically used in very cheap Access Points and Routers. > > > > Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx> > > Cc: Gabor Juhos <juhosg@xxxxxxxxxxx> > > Cc: Alban Bedel <albeu@xxxxxxx> > > Cc: linux-mips@xxxxxxxxxxxxxx > > Cc: devicetree@xxxxxxxxxxxxxxx > > --- > > arch/mips/boot/dts/qca/ar9331.dtsi | 123 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 123 insertions(+) > > > > diff --git a/arch/mips/boot/dts/qca/ar9331.dtsi b/arch/mips/boot/dts/qca/ar9331.dtsi > > new file mode 100644 > > index 0000000..bf128a2 > > --- /dev/null > > +++ b/arch/mips/boot/dts/qca/ar9331.dtsi > > @@ -0,0 +1,123 @@ > > +#include <dt-bindings/clock/ath79-clk.h> > > + > > +/ { > > + compatible = "qca,ar9331"; > > + > > [...] > > > + > > + extosc: oscillator { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + }; > > This oscillator is on the board and not in the SoC, so it should > be in the board DTS. This oscillator is always has to be connected to the SoC, it's abligatory thing. So there no logic incosistency in adding this oscillator node template to SoC's dtsi file. This oscillator node is not describes oscillator completely but this node makes it possible to introduce oscillator early so we can make reference on it just in ar9331.dtsi file. So we have no need to make full oscillator description in every board dts file. Futher is we make full oscillator' description in a board dts file then we have to additionally describe binding of the oscillator to SoC's clk block. -- Best regards, Antony Pavlov -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html