On Thu, Jan 28, 2016 at 11:38 PM, Will Deacon <will.deacon@xxxxxxx> wrote: > On Thu, Jan 28, 2016 at 10:42:17PM +0530, Ganapatrao Kulkarni wrote: >> On Thu, Jan 28, 2016 at 8:09 PM, Will Deacon <will.deacon@xxxxxxx> wrote: >> > On Tue, Jan 26, 2016 at 02:36:04PM -0600, Bjorn Helgaas wrote: >> >> Subject is "arm64/arm, numa, dt: adding ..." What is the significance >> >> of the "arm" part? The other patches only mention "arm64". >> >> >> >> General comment: the code below has little, if anything, that is >> >> actually arm64-specific. Maybe this is the first DT-based NUMA >> >> platform? I don't see other similar code for other arches, so maybe >> >> it's too early to try to generalize it, but we should try to avoid >> >> adding duplicates of this code if/when other arches do show up. >> > >> > Having it in the core code would allow us to share it with arch/arm/ >> > fairly straightforwardly. >> This binding can be used for arm too. >> however at this moment it is the need of arm64 platforms. >> can we please keep this to arm64 as it's too early to try to >> generalize it(as Bjorn suggested) >> I prefer to keep it as it is, otherwise ok. >> Please suggest. > > My suggestions time and time again on the NUMA patches from you have > consistently been around consolidation of existing code, or moving things > that aren't architecture-specific out of the architecture code. thanks, i shall move this out to drivers/of > > Will thanks Ganapat -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
