On Thursday 28 January 2016 00:36:56 Stephen Boyd wrote: > On 01/27, Arnd Bergmann wrote: > > On Wednesday 27 January 2016 17:56:18 James Liao wrote: > > > > > > > > I think you should include this change in your patch, or as a preparation. > > > > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM, > > > > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that > > > > selects COMMON_CLK. > > > > > > Oops, I didn't notice there are warnings after moving these Kconfigs > > > into menu section. > > > > > > The original motivation of this patch is preventing new clk drivers > > > include their Kconfig in a wrong place, so it's not critical. Do you > > > think we should apply this patch (with your changes below) or drop this > > > patch directly? > > > > > > I think your patch is good, we just need to fix S3C24xx, which is doing > > things in a strange way for historic reasons. > > So far we've taken the approach of not caring if they include > their Kconfig outside the common clk menu when all the configs > inside the Kconfig file are hidden. Of course, when they aren't > hidden this becomes a problem, but that isn't the case unless > something changed recently. They are all hidden, but there is no real reason for that I think (other than the samsung glitch). Having them inside the menu makes it possible to add '|| COMPILE_TEST' as a follow-up, and makes it more consistent overall. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
