On Tue, Jan 26, 2016 at 3:43 AM, Felipe Ferreri Tonello <eu@xxxxxxxxxxxxxxxxx> wrote: > Hi Rob, > > On 26/01/16 02:29, Rob Herring wrote: >> On Mon, Jan 25, 2016 at 05:53:23PM +0000, Felipe F. Tonello wrote: >>> This is the initial imx-cs427x device-tree-only machine driver working with >>> fsl_ssi driver. More features can be added on top of it later. >>> >>> Signed-off-by: Felipe F. Tonello <eu@xxxxxxxxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/sound/imx-audio-cs427x.txt | 47 +++++ >>> sound/soc/fsl/Kconfig | 12 ++ >>> sound/soc/fsl/Makefile | 2 + >>> sound/soc/fsl/imx-cs427x.c | 218 +++++++++++++++++++++ >>> 4 files changed, 279 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-cs427x.txt >>> create mode 100644 sound/soc/fsl/imx-cs427x.c >>> >>> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-cs427x.txt b/Documentation/devicetree/bindings/sound/imx-audio-cs427x.txt >>> new file mode 100644 >>> index 000000000000..295f60b19418 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/imx-audio-cs427x.txt >>> @@ -0,0 +1,47 @@ >>> +Freescale i.MX audio complex with CS4271 or CS4272 codec >> >> Do all the i.MX audio bindings really vary more that the codec? Seems >> like a lot of duplication. > > I agree, but that how it is today. These platform drivers for imx are > similar but not identical. Looking at them I would guess that they have > 50 to 60% of duplicated code. > > I believe we can add this driver and work on re-using the code on a > future series of patches. > >> >>> + >>> +Required properties: >>> + >>> + - compatible : "fsl,imx-audio-cs427x" >>> + >>> + - model : The user-visible name of this sound complex >>> + >>> + - ssi-controller : The phandle of the i.MX SSI controller >>> + >>> + - audio-codec : The phandle of the CS4271 audio codec >>> + >>> + - audio-routing : A list of the connections between audio components. >>> + Each entry is a pair of strings, the first being the >>> + connection's sink, the second being the connection's >>> + source. Valid names could be power supplies, CS427x >>> + pins, and the jacks on the board: >>> + >>> + Board connectors: >>> + * Mic Jack >>> + * Headphone Jack >> >> This should be an exact list of possible strings and valid combinations. > > This is the exact list for this version of this driver. At least that is > what I can verify on my hardware (custom build). What are AINA, AINB, etc. then? Also, model should have its string documented. I should be able to write the example from the documentation. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
