Hi Aaro, On sam., janv. 23 2016, Aaro Koskinen <aaro.koskinen@xxxxxx> wrote: > Fix audio on kirkwood-openrd-client: > > 1) The audio-controller was left disabled. > > 2) The probe fails because cs42l51 is missing #sound-dai-cells. > > /sound/simple-audio-card,codec: could not get #sound-dai-cells for /ocp@f1000000/i2c@11000/cs42l51@4a > asoc-simple-card sound: parse error -22 > asoc-simple-card: probe of sound failed with error -22 > > 3) The mapping is incorrect: > > asoc-simple-card sound: cs42l51-hifi <-> spdif mapping ok > > should be: > > asoc-simple-card sound: cs42l51-hifi <-> i2s mapping ok > > Reported-by: Rick Thomas <rbthomas@xxxxxxxxx> > Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx> Applied on mvebu/dt with Reviewed-by tag from Andrew Lunn and Tested-by tag from Rick Thomas. Thanks, Gregory > --- > arch/arm/boot/dts/kirkwood-openrd-client.dts | 6 +++++- > arch/arm/boot/dts/kirkwood.dtsi | 2 +- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/kirkwood-openrd-client.dts b/arch/arm/boot/dts/kirkwood-openrd-client.dts > index 887b9c1..96ff59d 100644 > --- a/arch/arm/boot/dts/kirkwood-openrd-client.dts > +++ b/arch/arm/boot/dts/kirkwood-openrd-client.dts > @@ -20,6 +20,9 @@ > compatible = "marvell,openrd-client", "marvell,openrd", "marvell,kirkwood-88f6281", "marvell,kirkwood"; > > ocp@f1000000 { > + audio-controller@a0000 { > + status = "okay"; > + }; > i2c@11000 { > status = "okay"; > clock-frequency = <400000>; > @@ -27,6 +30,7 @@ > cs42l51: cs42l51@4a { > compatible = "cirrus,cs42l51"; > reg = <0x4a>; > + #sound-dai-cells = <0>; > }; > }; > }; > @@ -37,7 +41,7 @@ > simple-audio-card,mclk-fs = <256>; > > simple-audio-card,cpu { > - sound-dai = <&audio0>; > + sound-dai = <&audio0 0>; > }; > > simple-audio-card,codec { > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi > index 7b5a4a1..7445a15 100644 > --- a/arch/arm/boot/dts/kirkwood.dtsi > +++ b/arch/arm/boot/dts/kirkwood.dtsi > @@ -381,7 +381,7 @@ > > audio0: audio-controller@a0000 { > compatible = "marvell,kirkwood-audio"; > - #sound-dai-cells = <0>; > + #sound-dai-cells = <1>; > reg = <0xa0000 0x2210>; > interrupts = <24>; > clocks = <&gate_clk 9>; > -- > 2.4.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html