Hi Krzysztof, > 2015-10-30 1:37 GMT+09:00 Ramakrishna Pallala > <ramakrishna.pallala@xxxxxxxxx>: > > This patch adds the device tree documentation for TI BQ24261 charger. > > > > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx> > > Signed-off-by: Jenny TC <jenny.tc@xxxxxxxxx> > > --- > > .../devicetree/bindings/power/bq24261.txt | 34 > ++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/power/bq24261.txt > > > > diff --git a/Documentation/devicetree/bindings/power/bq24261.txt > > b/Documentation/devicetree/bindings/power/bq24261.txt > > new file mode 100644 > > index 0000000..e18f6dc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/bq24261.txt > > @@ -0,0 +1,34 @@ > > +Binding for TI bq24261 Li-Ion Charger > > + > > +Required properties: > > +- compatible: Should contain one of the following: > > + * "ti,bq24261" > > Just: 'should be "ti,bq24261"'. Ok. > > +- reg: integer, i2c address of the device. > > +- ti,battery-regulation-voltage: integer, maximum charging voltage in uV. > > +- ti,charge-current: integer, maximum charging current in uA. > > +- ti,termination-current: integer, charge will be terminated when current in > > + constant-voltage phase drops below this value (in uA). > > Same as proposed extension of bq24257.txt. I like it. > > > + > > +Optional properties: > > +- ti,max-charge-current: integer, maximum charging current (in uA); > > I did not look at the code yet but description of property is exactly the same as > "ti,charge-current"... Two different properties with same description? > > > +- ti,max-charge-voltage: integer, maximum charging voltage (in uV); > > Ditto. I will fix it. > > +- ti,min-charge-temperature: integer, minimum charging temperature > > +(in DegC); > > +- ti,max-charge-temperature: integer, maximum charging temperature (in > DegC). > > +- ti,thermal-sensing: integer, enable(1) or disable(0) JEITA thermal control. > > You made it integer instead of boolean, so just to be sure - you expect the > possibility of overriding this property or extending it in further devices? Yes. Thanks. Thanks, Ram ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f