On Thu, Jan 21, 2016 at 03:53:19PM +0100, Petr Kulhavy wrote: > TI DaVinci MUSB driver equipped with DeviceTree support. > Tested with AM1808 board and USB2.0 (OTG) in host mode. > > Signed-off-by: Petr Kulhavy <petr@xxxxxxxxx> > --- > .../devicetree/bindings/usb/da8xx-usb.txt | 52 +++++++ > drivers/usb/musb/da8xx.c | 166 +++++++++++++++++++++ > include/linux/platform_data/usb-davinci.h | 3 +- > 3 files changed, 220 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt > > diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt > new file mode 100644 > index 0000000..c81d665 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt Follow the compatible string for the filename (with wildcards is fine). > @@ -0,0 +1,52 @@ > +TI DaVinci MUSB > + > +Required properties: > + > + - compatible : Should be "ti,da850-musb" or "ti,da830-musb" > + > + - mode : USB mode. "1" signifies HOST, "2" represents PERIPHERAL, > + "3" represents OTG. Surely we have a similar property defined already. Don't create something new. > + > + - power : This signifies the maximum current the controller can > + supply in host mode. The unit size is 2mA, the maximum value is 510mA. You should model this as a regulator. > + - num-eps : Specifies the number of endpoints. This is also a > + MUSB configuration-specific setting. Just spell out endpoints. > + > + - multipoint : Should be "1" indicating the musb controller supports > + multipoint. This is a MUSB configuration-specific setting. What does multipoint mean? > + - ram-bits : Specifies the ram address size. Needs a better description. Then it probably needs a better name too, but without a description I can't tell what that would be. > + > + > +Optional properties: > + > + - da8xx,phy20-clkmux-cfg: Integer. Defines the USB 2.0 PHY reference clock source. > + Supported values: "0" for external pin, "1" for internal PLL. How about a boolean property instead. Name it based on the less used option (external pin I'm guessing). > + - da8xx,phy20-refclock-frequency : Integer. Defines the USB 2.0 PHY reference clock input > + frequency in Hz in case the clock is generated by the internal PLL. > + Supported values are 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz da8xx is not a vendor. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
