Re: [PATCH v2 1/3] Documentation: Update the APM X-Gene SoC EDAC DTS binding for missing RB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Jan 19, 2016 at 05:46:50PM -0700, Loc Ho wrote:
> This patch updates the APM X-Gene SoC EDAC documentation binding to
> reference the missing register bus for the the SoC EDAC.
> 
> Signed-off-by: Loc Ho <lho@xxxxxxx>
> ---
>  .../devicetree/bindings/edac/apm-xgene-edac.txt    |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/edac/apm-xgene-edac.txt b/Documentation/devicetree/bindings/edac/apm-xgene-edac.txt
> index 78e2a31..17b29af 100644
> --- a/Documentation/devicetree/bindings/edac/apm-xgene-edac.txt
> +++ b/Documentation/devicetree/bindings/edac/apm-xgene-edac.txt
> @@ -20,6 +20,12 @@ Required properties:
>  - interrupts            : Interrupt-specifier for MCU, PMD, L3, or SoC error
>  			  IRQ(s).
>  
> +Optional property:
> +- regmap-rb		: Regmap of the register bus resource. This properity

s/properity/property/

> +			  is optional only for compatibility. If the RB
> +			  erorr conditions are not cleared, it will
> +			  continuously generates interrupt.

s/generates/generate/

Given this is pretty much required. I think I would move this back to 
required in the documentation, but keep the driver to allow it to be 
missing.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux