>>>>> "Yang," == Yang, Wenyou <Wenyou.Yang@xxxxxxxxx> writes: Hi, >> Why not make it a tristate instead? Having regulators as modules is perhaps not a >> very wise thing to do, but conceptually I don't see why this code couldn't be a >> module. > Yes, you are right. it can be use a tristate. Ok, good. >> > + act8945a = devm_kzalloc(&i2c->dev, sizeof(*act8945a), GFP_KERNEL); >> > + if (!act8945a) >> > + return -ENOMEM; >> > + >> >> What is the point of this structure (and the header file)? Can't the subdevices just >> do dev_get_regmap(dev->parent)? regulator_register() afaik already does this by >> default. > Yes, I re-read regulator_register() code. It did do dev_get_regmap(dev->parent). > I think this structure should be pointed by dev->parent, this structure is necessary. > Yes regulator driver should be simpler. > Moreover, it is used by another sub device, charger. Which don't such code. But the charger driver can just as well do: dev_get_regmap(dev->parent); instead of: dev_get_drvdata(pdev->dev.parent)->regmap. -- Venlig hilsen, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
