Hello, Suman.
Your mails ended up in spam again and it looks to be from SPF failure.
Received-SPF: softfail (google.com: domain of transitioning stripath@xxxxxxx does not designate 198.145.29.136 as permitted sender) client-ip=198.145.29.136;
Authentication-Results: mx.google.com;
spf=softfail (google.com: domain of transitioning stripath@xxxxxxx does not designate 198.145.29.136 as permitted sender) smtp.mailfrom=stripath@xxxxxxx;
dmarc=fail (p=QUARANTINE dis=NONE) header.from=apm.com
Can you please look into it?
On Thu, Jan 14, 2016 at 11:00:23AM +0530, Suman Tripathi wrote:
> static irqreturn_t ahci_single_edge_irq_intr(int irq, void *dev_instance)
> {
> @@ -2517,16 +2518,21 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
> {
> struct ahci_host_priv *hpriv = host->private_data;
> int irq = hpriv->irq;
> + irqreturn_t (*ahci_irq_handler)(int irq, void *dev_instance);
> int rc;
>
> if (hpriv->flags & AHCI_HFLAG_MULTI_MSI)
> rc = ahci_host_activate_multi_irqs(host, irq, sht);
> - else if (hpriv->flags & AHCI_HFLAG_EDGE_IRQ)
> - rc = ata_host_activate(host, irq, ahci_single_edge_irq_intr,
> - IRQF_SHARED, sht);
> - else
> - rc = ata_host_activate(host, irq, ahci_single_level_irq_intr,
> + else {
> + ahci_irq_handler = hpriv->ahci_irq_intr ? hpriv->ahci_irq_intr :
> + (hpriv->flags & AHCI_HFLAG_EDGE_IRQ ?
> + ahci_single_edge_irq_intr :
> + ahci_single_level_irq_intr);
> +
> + rc = ata_host_activate(host, irq, ahci_irq_handler,
> IRQF_SHARED, sht);
> + }
> +
So, if we have ->ahci_irq_intr, we don't need AHCI_HFLAG_EDGE_IRQ at
all, right? Just initialize ->ahci_irq_intr to
ahci_single_level_irq_intr and let specific drivers overrie it?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
