Hi Rob, > -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: 2016年1月9日 23:38 > To: Yang, Wenyou <Wenyou.Yang@xxxxxxxxx> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>; Pawel Moll <pawel.moll@xxxxxxx>; Mark > Rutland <mark.rutland@xxxxxxx>; Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>; > Kumar Gala <galak@xxxxxxxxxxxxxx>; Ferre, Nicolas > <Nicolas.FERRE@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings > > On Fri, Jan 08, 2016 at 10:05:28AM +0800, Wenyou Yang wrote: > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two > > subdevices: > > - Regulator > > - Charger > > > > This patch adds documentation for ACT8945A DT bindings. > > > > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx> > > One nit, otherwise: > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 16 > ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt > > b/Documentation/devicetree/bindings/mfd/act8945a.txt > > new file mode 100644 > > index 0000000..406db16 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt > > @@ -0,0 +1,16 @@ > > +Device-Tree bindings for Active-semi ACT8945A MFD driver > > + > > +Required properties: > > + - compatible: "active-semi,act8945a". > > + - reg: the I2C slave address for the ACT8945A chip > > + > > +The chip exposes two subdevices: > > + - a regulators: see ../regulator/act8945a-regulator.txt > > + - a charger: see ../power/act8945a-charger.txt > > + > > +Example: > > + mfd: act8945a@5b { > > s/act8945a/pmic/ The patch is changed in the next verion, add the pmic and charger nodes. So, I am not add your Acked-by. > > > + compatible = "active-semi,act8945a"; > > + reg = <0x5b>; > > + status = "okay"; > > + }; > > -- > > 1.7.9.5 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > > info at http://vger.kernel.org/majordomo-info.html Best Regards, Wenyou Yang ?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
