On Monday 11 January 2016 17:34:52 Scott Wood wrote: > >> > >> I think you need a 'depends on THERMAL' to prevent the driver from being > >> built-in when THERMAL=m. > >> > >> Arnd > > > > Correct. I need to add following lines to the Kconfig file: > > depends on !CPU_THERMAL || THERMAL=y > > > > Hi Rafael, > > Should I send a new patch include this fix or send a fix patch? > > Why THERMAL=y and not just THERMAL, which would allow building this > driver as a module? Right, that would be better, and it is what all other drivers do. For some reason, some drivers depend on !CPU_THERMAL and others depend on !THERMAL_OF here, and I think the result is the same, but we are a bit inconsistent here. CPU_THERMAL cannot be set if THERMAL_OF is disabled, and the header file only uses the 'extern' declaration if both are set. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
