On 2016/1/11 11:09, Rob Herring wrote: > On Sun, Jan 10, 2016 at 7:20 PM, xuejiancheng <xuejiancheng@xxxxxxxxxx> wrote: >> Hi Rob, >> >> On 2016/1/9 23:42, Rob Herring wrote: >>> On Fri, Jan 08, 2016 at 09:26:45AM +0800, Jiancheng Xue wrote: >>>> add hisilicon spi-nor flash controller driver >>>> >>>> Signed-off-by: Binquan Peng <pengbinquan@xxxxxxxxxx> >>>> Signed-off-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxx> >>>> --- > >>>> +Required properties: >>>> +- compatible : Should be "hisilicon,hisi-sfc". >>> >>> I missed this last time, but you also need a more specific compatible >>> string with the SOC name in it. >>> >> >> This IP block is used in many SOCs. Do I need to add a specific compatible >> string for every SOC? Thank you. > > Yes. You can keep the generic one for driver matching, but you want to > have the specific one in case there ever is a quirk/errata in a > specific SOC. > I see. Thank you. > Rob > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
