> Martin Sperl <kernel@xxxxxxxxxxxxxxxx> hat am 10. Januar 2016 um 16:45 > geschrieben: > > > > > On 10.01.2016, at 16:05, Stefan Wahren <stefan.wahren@xxxxxxxx> wrote: > > > > Hi Martin, > > > >> kernel@xxxxxxxxxxxxxxxx hat am 9. Januar 2016 um 14:07 geschrieben: > >> > >> > >> From: Martin Sperl <kernel@xxxxxxxxxxxxxxxx> > >> > >> This patch series adds the bcm2835aux uart driver, which is created > >> as a wrapper arround the 8250 driver (based on recommendations by > >> Stephen Warren) > >> > >> The device tree patch itself is not included yet because this > >> patch requires the clk-bcm2835aux driver, which is right now only > >> in clk-next, but should become available with 4.5. > > > > it doesn't make sense without the device tree patch. IMHO it's okay as long > > as > > you point out the dependency and set the node status to disable. > > I agree in principle, but it is the same as with the spi-bcm2835aux driver, > where I had provided a patch to the dt, that still has not been applied > yet, but with the driver itself already in the kernel. Please provide a new version, because it won't apply anymore. It increase the chance of more testing. > > Also the reorganisation of the dt to support the bcm2836 makes this > another moving target. > > The other concern is that we would need to use defines included > from "dt-bindings/clock/bcm2835aux.h” and without those the dt will not > work. AFAIK there has been a discussion about such a problem. > > For the record: this is what would be required: > uart1: uart@7e215040 { > compatible = "brcm,bcm2835-aux-uart"; > reg = <0x7e215040 0x40>; > interrupts = <1 29>; > clocks = <&aux BCM2835_AUX_CLOCK_UART>; > status = "disabled"; > }; > > I can respin the whole patchset to include this as well if you tell me to. I think we should wait for a rpi maintainer's response about that. No need to hurry. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html