On Fri, Jan 08, 2016 at 10:15:28PM +0800, John Garry wrote: > + /* Global registers init*/ > + if (of_get_property(np, "am-max-trans", NULL)) { > + hisi_sas_write32(hisi_hba, AM_CFG_MAX_TRANS, 0x2020); > + hisi_sas_write32(hisi_hba, AM_CFG_SINGLE_PORT_MAX_TRANS, > + 0x2020); > + } Use of_property_read_bool for boolean properties like this. I still don't follow exactly what this property means, and why it is necessary, but that's an issue for the binding document. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html