On Fri, Jan 8, 2016 at 12:06 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote: > Thanks Rob for review. > I have taken care of all comment except following which I have query. > > On Friday 08 January 2016 04:42 AM, Rob Herring wrote: >> >> + - maxim,low-battery-reset-enable: Enable low battery reset. >> + - maxim,low-battery-reset-disable: Disable low battery reset. >> Why not boolean? Not present means keep default value? I'd prefer >> boolean or tristate of not present, 0 to disable, or 1 to enable. >> >> > Here, the properties are boolean. I will add this on the description. > > I like to enable or disable with the DT and properties are not there then > left to default. > So added two properties for enable and disable. If properties are there, do > the activity. > > Here tristate is also possible: > maxim,low-battery-reset: tristate, low battery reset control. 0 for disable, > 1 for enable and > absence of this will leave configuration on > default. > > Does it look fine? Yes. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
