RE: [PATCH 4/6] arm64: renesas: salvator-x: enable usb2_phy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Geert-san,

> From: Geert Uytterhoeven
> Sent: Tuesday, January 05, 2016 9:56 PM
> 
> Hi Shimoda-san,
> 
> On Fri, Dec 25, 2015 at 11:03 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 34 +++++++++++++++++++++-
> >  1 file changed, 33 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > index 265d12f..7353407 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > @@ -122,8 +122,22 @@
> >                                  "audio_clkout_a", "audio_clkout3_a";
> >                 renesas,function = "audio_clk";
> >         };
> > -};
> >
> > +       usb0_pins: usb0 {
> > +               renesas,groups = "usb0";
> > +               renesas,function = "usb";
> > +       };
> > +
> > +       usb1_pins: usb1 {
> > +               renesas,groups = "usb1";
> > +               renesas,function = "usb";
> > +       };
> > +
> > +       usb2_pins: usb2 {
> > +               renesas,groups = "usb2";
> > +               renesas,function = "usb";
> > +       };
> 
> sh-pfc e6060000.pfc: function 'usb' not supported
> sh-pfc e6060000.pfc: invalid function usb in map table
> sh-pfc e6060000.pfc: function 'usb' not supported
> sh-pfc e6060000.pfc: invalid function usb in map table
> sh-pfc e6060000.pfc: function 'usb' not supported
> sh-pfc e6060000.pfc: invalid function usb in map table
> 
> As the usb patches for pfc-r8a7795 haven't been posted yet, it's difficult
> to test/comment.
> 
> Note that the functions were called "usb%u" in a previous version, and in the
> pfc-r8a7795 code in the BSP.
> 
> Can you please post the pfc-r8a7795 patches, too?

Thank you for the point. I overlooked these error messages because
usb host functions worked correctly...

Anyway, I will make the pfc-r8a7795 patches for it later.

Best regards,
Yoshihiro Shimoda

> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux