On Sun, Dec 20, 2015 at 01:43:58PM +0300, Sergei Ianovich wrote: > On Sat, 2015-12-19 at 21:38 -0600, Rob Herring wrote: > > On Tue, Dec 15, 2015 at 09:58:53PM +0300, Sergei Ianovich wrote: > > > +Required properties: > > > +- compatible : should be "icpdas,sram-lp8x4x" > > > > No wildcards please. Otherwise looks fine. > > There is a similar review comment from Arnd Bergmann in the discussion > of `[PATCH v5] serial: support for 16550A serial ports on LP-8x4x`. > > I'll quote my latest clarification: > > ... This driver will support ports on LP-8081, ^^ So 8081 doesn't even match the wildcard scheme you give in the compatible string, proving the point of the Conventional Wisdom suggestion Rob gave... > > LP-8141, LP-8441, LP-8841. Last time I checked the vendor was announcing > > a series with 3 as the last digit. They use lp8x4x name, eg. in > > documentation like `LP-8x4x_ChangeLog.txt`. They ship their proprietary > > SDK in `lp8x4x_sdk_for_linux.tar`. All of this implies that it is a > > single board. > > I think the solution should be the same for all LP-8x4x drivers (IRQ, > SRAM, SERIAL, IIO). The rationale is described here: http://devicetree.org/Device_Tree_Usage#Understanding_the_compatible_Property Quote: > Warning: Don't use wildcard compatible values, like "fsl,mpc83xx-uart" > or similar. Silicon vendors will invariably make a change that breaks > your wildcard assumptions the moment it is too late to change it. > Instead, choose a specific silicon implementations and make all > subsequent silicon compatible with it. I don't think your circumstance is anything unique. Regards, Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
