On Tuesday 05 November 2013, Jason Gunthorpe wrote:
> I've been brewing a patch set to fix TPM, but it is a large effort. I
> would think other legacy subsystems that are not fully class device
> enabled will have similar challenges?
I think a common pattern is to have the subsystem data be referenced from
the driver data using a pointer, and contain a back reference to the struct
device, which should not be a problem.
> How about an alternate entry point:
>
> net = alloc_etherdev(sizeof(foo_priv));
> priv = netdev_priv(net);
> devm_probe_priv(priv, probes);
>
> Don't touch the drvdata for that flow.
Yes, that would work, but it would prevent another idea I had that I haven't
mentioned here: If we add a pointer to the 'struct devm_probe' array to
'struct device_driver', those can actually be called by the driver core
code before entering the probe() callback, or potentially replace the
probe() function entirely for simple drivers (provided we add a few more
bits that we haven't talked about here.
I was originally thinking of something like
int devm_probe_alloc_netdev(struct device *dev, struct devm_probe *probe)
{
struct net_device *netdev, **netdevp;
/* open-coded devm_alloc_ethernet */
netdevp = devres_alloc(devm_free_netdev, sizeof (*netdevp), GFP_KERNEL);
if (!netdevp)
return -ENOMEM;
netdev = alloc_etherdev(probe->size);
if (!netdev) {
devres_free(netdevp);
return -ENOMEM;
}
*netdevp = netdev;
devres_add(dev, netdevp);
dev_set_drvdata(dev, netdev_priv(netdev));
netdevp = dev_get_drvdata(dev) + probe->offset;
*netdevp = netdev;
}
#define DEVM_ALLOC_NETDEV(_struct, _member) { \
.initfunc = devm_probe_alloc_netdev, \
.size = sizeof(struct _struct), \
.offset = offsetof_t(struct _struct, _member, struct netdev *), \
}
which would fit in nicely with the rest of the design, but now I'm no longer
sure if that would actually work with the lifetime rules of the netdev, which
would pin the refcount on the 'struct device', which in turn could prevent
the devres cleanup to be executed.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
