On Tue, Dec 29, 2015 at 9:17 PM, Yao Yuan <yao.yuan@xxxxxxx> wrote: > Hi Rob, > > Thanks for your review. > So you mean that I should add the commit message for why I add this new compatible? Please don't top post on the lists. No, the binding doc should explain what are valid combinations of compatible strings and the order when the dts can have multiple strings. For example, is this valid: compatible = "fsl,vf610-dspi", "fsl,ls2080a-dspi"; In other words, I should be able to check a dts file against what the binding doc says. Rob > On Wed, Dec 30, 2015 at 02:35AM, Rob Herring wrote: >> On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote: >> > new compatible string: "fsl,ls2080a-qspi". >> > >> > Signed-off-by: Yuan Yao <yao.yuan@xxxxxxx> >> > --- >> > Changed in v2: >> > Update my email to <yao.yuan@xxxxxxx> >> > --- >> > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > index fa77f87..2fe51d6 100644 >> > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > @@ -1,7 +1,8 @@ >> > ARM Freescale DSPI controller >> > >> > Required properties: >> > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" >> > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", >> > + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi" >> >> You should explain what combinations of compatible strings are valid. >> >> Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
