On Nov 5, 2013, at 11:46 AM, Stephen Boyd wrote: > On 11/05/13 09:43, Kumar Gala wrote: >> On Nov 5, 2013, at 11:35 AM, Stephen Boyd wrote: >> >>> On 11/05/13 09:12, Kumar Gala wrote: >>>> I think this should be more specific than just 'qcom,mmio' or 'qcom,warm-boot'. It should be 'qcom,kpss-acc-v1' or 'qcom-gcc-8660'. >>>> >>> Do you have any reasons why? I don't see why we need to keep adding more >>> and more enable-methods every time the subsystem surrounding the CPU >>> changes. The method is the same, write some registers to power up the >>> CPU for the first time (cold boot) or ping the CPU to wake it up >>> (warmboot). The only difference is where those registers live and a >>> slight variation in the sequence that we perform. >> By that argument every device could just be compatible with 'mmio' and be done with it ;) >> >> As the registers you write vary, the compatible should vary. > > The compatible does vary. The enable-method is not a compatible property. > > -- I've always felt that the enable-method is equivalent of a compatible property. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
