On Tue, Dec 22, 2015 at 05:41:22PM +0800, Vishnu Patekar wrote: > >> + clocks { > >> + #address-cells = <1>; > >> + #size-cells = <1>; > >> + ranges; > >> + > >> + osc24M: osc24M_clk { > >> + #clock-cells = <0>; > >> + compatible = "fixed-clock"; > >> + clock-frequency = <24000000>; > >> + clock-output-names = "osc24M"; > >> + }; > >> + > >> + osc32k: osc32k_clk { > >> + #clock-cells = <0>; > >> + compatible = "fixed-clock"; > >> + clock-frequency = <32768>; > >> + clock-output-names = "osc32k"; > >> + }; > > > > Do you need to modify the clocks driver in your first commit then? > I did not get what you are trying to say here, could you please elaborate? > > I'll correct mistakes, and re-send this patch, is it okie? In your first patch, you add a CLK_OF_DECLARE for the H3 compatible in clk-sunxi.c Judging from your clocks node above, you don't need it at all. I'm guessing you'll need it later on, but I wanted to know if that was intentional :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature