On Tue, Dec 15, 2015 at 12:19 AM, Andrew F. Davis <afd@xxxxxx> wrote: > [Rob] >> I agree the generic version is fine (or find who made the first part >> ;)). What "pisosr" is is not very obvious though. Having 74165 in the >> compatible would make it somewhat more obvious it is a standard logic >> part. >> > > A quick search shows shift-registers being made from vacuum tubes for > the Colossus! Those might work with this driver if you could match the > voltage to an SPI bus... :) > > I agree about the name not being very good, but I'm not sure about > 74165 ether as it is also just a single part number. We can add many compatible strings so it's not an issue. "ti,74165" works for me as TI invented the 74xx series. > The idea was to > have a non-part number compatible string for any shift-register you > can hook to the SPI line. Again, one does not exclude the other. I'm happy with a generic compatible *and* "ti,74165". > That way when we have boards with a sn65x882 > or something we wont have to call it a 74165. But I guess that's why > it's a "compatible:" string, and not "is-a:" string. Compatible ranges from the specific to the more generic so compatible = "ti,74165", "pisosr"; is just fine. Something will match if there is a suitable driver. The OS may choose to provide something part-specific or something more generic. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html