Hello Wens, On Tue, Dec 22, 2015 at 11:12 AM, Chen-Yu Tsai <wens@xxxxxxxx> wrote: > On Sat, Dec 19, 2015 at 5:41 AM, Maxime Ripard > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: >> Hi, >> >> On Fri, Dec 18, 2015 at 09:30:50PM +0800, Vishnu Patekar wrote: >>> Allwinner A83T is new octa-core cortex-a7 SOC. >>> This adds the basic dtsi, the clocks differs from >>> earlier sun8i SOCs. >>> >>> Signed-off-by: Vishnu Patekar <vishnupatekar0510@xxxxxxxxx> >>> --- >>> arch/arm/boot/dts/sun8i-a83t.dtsi | 206 ++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 206 insertions(+) >>> create mode 100644 arch/arm/boot/dts/sun8i-a83t.dtsi >>> >>> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >>> new file mode 100644 >>> index 0000000..e577c64 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >>> @@ -0,0 +1,206 @@ >>> +/* >>> + * Copyright 2015 Vishnu Patekar >>> + * >>> + * Vishnu Patekar <vishnupatekar0510@xxxxxxxxx> >>> + * >>> + * This file is dual-licensed: you can use it either under the terms >>> + * of the GPL or the X11 license, at your option. Note that this dual >>> + * licensing only applies to this file, and not this project as a >>> + * whole. >>> + * >>> + * a) This file is free software; you can redistribute it and/or >>> + * modify it under the terms of the GNU General Public License as >>> + * published by the Free Software Foundation; either version 2 of the >>> + * License, or (at your option) any later version. >>> + * >>> + * This file is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + * >>> + * Or, alternatively, >>> + * >>> + * b) Permission is hereby granted, free of charge, to any person >>> + * obtaining a copy of this software and associated documentation >>> + * files (the "Software"), to deal in the Software without >>> + * restriction, including without limitation the rights to use, >>> + * copy, modify, merge, publish, distribute, sublicense, and/or >>> + * sell copies of the Software, and to permit persons to whom the >>> + * Software is furnished to do so, subject to the following >>> + * conditions: >>> + * >>> + * The above copyright notice and this permission notice shall be >>> + * included in all copies or substantial portions of the Software. >>> + * >>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >>> + * OTHER DEALINGS IN THE SOFTWARE. >>> + >>> + */ >>> + >>> +#include "skeleton.dtsi" >>> + >>> +#include <dt-bindings/interrupt-controller/arm-gic.h> >>> + >>> +#include <dt-bindings/pinctrl/sun4i-a10.h> >>> + >>> +/ { >>> + interrupt-parent = <&gic>; >>> + >>> + chosen { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + }; >>> + >>> + cpus { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + cpu@0 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <0>; >>> + }; >>> + >>> + cpu@1 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <1>; >>> + }; >>> + >>> + cpu@2 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <2>; >>> + }; >>> + >>> + cpu@3 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <3>; >>> + }; >> >> A \n here please >> >>> + cpu@100 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <0x100>; >>> + }; >>> + >>> + cpu@101 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <0x101>; >>> + }; >> >> Ditto. >> >>> + cpu@102 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <0x102>; >>> + }; >>> + >>> + cpu@103 { >>> + compatible = "arm,cortex-a7"; >>> + device_type = "cpu"; >>> + reg = <0x103>; >>> + }; >>> + }; >>> + >>> + memory { >>> + reg = <0x40000000 0x80000000>; >>> + }; >> >> Is mainline u-boot usable ? If so, you can remove that node entirely. >> >>> + >>> + timer { >>> + compatible = "arm,armv7-timer"; >>> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, >>> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, >>> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, >>> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; >>> + }; >>> + >>> + clocks { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + >>> + osc24M: osc24M_clk { >>> + #clock-cells = <0>; >>> + compatible = "fixed-clock"; >>> + clock-frequency = <24000000>; >>> + clock-output-names = "osc24M"; >>> + }; >>> + >>> + osc32k: osc32k_clk { >>> + #clock-cells = <0>; >>> + compatible = "fixed-clock"; >>> + clock-frequency = <32768>; >>> + clock-output-names = "osc32k"; >>> + }; >> >> Do you need to modify the clocks driver in your first commit then? >> >>> + }; >>> + >>> + soc { >>> + compatible = "simple-bus"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + >>> + gic: interrupt-controller@01c81000 { >>> + compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; >>> + reg = <0x01c81000 0x1000>, >>> + <0x01c82000 0x1000>, >>> + <0x01c84000 0x2000>, >>> + <0x01c86000 0x2000>; >> >> Please order the nodes by ascending physical addresses. >> >>> + interrupt-controller; >>> + #interrupt-cells = <3>; >>> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; >>> + }; >>> + >>> + pio: pinctrl@01c20800 { >>> + compatible = "allwinner,sun8i-a83t-pinctrl"; >>> + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>, >>> + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, >>> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; >>> + reg = <0x01c20800 0x400>; >>> + clocks = <&osc24M>; >>> + gpio-controller; >>> + interrupt-controller; >>> + #interrupt-cells = <3>; >>> + #gpio-cells = <3>; >>> + >>> + mmc0_pins_a: mmc0@0 { >>> + allwinner,pins = "PF0", "PF1", "PF2", >>> + "PF3", "PF4", "PF5"; >>> + allwinner,function = "mmc0"; >>> + allwinner,drive = <SUN4I_PINCTRL_30_MA>; >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; >>> + }; >>> + >>> + uart0_pins_a: uart0@0 { >>> + allwinner,pins = "PF2", "PF4"; >>> + allwinner,function = "uart0"; >>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; >>> + }; > > I don't see much use for the UART0 PF pins once we have mmc working. > > ChenYu I've received my Onda 989 Air based on A83T, I do not find another UART on it, rather I did not spend enough time to find. These nodes will help me adding nodes locally everytime I use Onda Air using microSD Breakout Board, I request to keep those. > >>> + >>> + uart0_pins_b: uart0@1 { >>> + allwinner,pins = "PB9", "PB10"; >>> + allwinner,function = "uart0"; >>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; >>> + }; >>> + }; >>> + >>> + uart0: serial@01c28000 { >>> + compatible = "snps,dw-apb-uart"; >>> + reg = <0x01c28000 0x400>; >>> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; >>> + reg-shift = <2>; >>> + reg-io-width = <4>; >>> + clocks = <&osc24M>; >>> + status = "disabled"; >>> + }; >>> + }; >>> +}; >> >> Thanks! >> Maxime >> >> -- >> Maxime Ripard, Free Electrons >> Embedded Linux, Kernel and Android engineering >> http://free-electrons.com > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@xxxxxxxxxxxxxxxx. > For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html