Ulf Hansson <ulf.hansson@xxxxxxxxxx> writes: > On 17 December 2015 at 01:26, Eric Anholt <eric@xxxxxxxxxx> wrote: >> From: Alexander Aring <alex.aring@xxxxxxxxx> >> >> This patch adds support for several power domains on Raspberry Pi, >> including USB (so it can be enabled even if the bootloader didn't do >> it), and graphics. >> >> This patch is the combined work of Eric Anholt (who wrote USB support >> inside of the Raspberry Pi firmware driver, and wrote the non-USB >> domain support) and Alexander Aring (who separated the original USB >> work out from the firmware driver). >> >> Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx> >> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx> >> --- >> >> v2: Add support for power domains other than USB, using the new >> firmware interface, reword commit message (changes by Eric) >> >> v3: Restructure as a builtin driver, and drop >> of_genpd_add_provider_onecell error handling to avoid >> pm_genpd_exit() dependency until that API can be settled. Clean >> up copyright header, add missing ISP initialization, and fix typo >> in transposer's name. >> >> v4: Move to drivers/soc/bcm/, move include to dt-bindings/soc/, set up >> Makefile for the drivers/soc/bcm following clk/'s model. >> >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/bcm/Kconfig | 9 + >> drivers/soc/bcm/Makefile | 1 + >> drivers/soc/bcm/raspberrypi-power.c | 247 ++++++++++++++++++++++++++++ >> include/dt-bindings/soc/raspberrypi-power.h | 41 +++++ > > There is currently a directory which I think may be better. > include/dt-bindings/power/* > > Besides this nitpick, I think this looks good. You may add my: > > Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Thanks! I'll be sending my pull requests with the two r-bs added and these nitpicks fixed.
Attachment:
signature.asc
Description: PGP signature
