Hell Sergei, On 21.12.2015 14:43, Sergei Shtylyov wrote: > Hello. > > On 12/20/2015 2:32 AM, Vladimir Zapolskiy wrote: > >> The change adds fixed voltage regulator for SD controller, ARM MMCI >> controller driver uses it to control card power management. >> >> Signed-off-by: Vladimir Zapolskiy <vz@xxxxxxxxx> >> --- >> arch/arm/boot/dts/phy3250.dts | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/phy3250.dts b/arch/arm/boot/dts/phy3250.dts >> index 34e15fd..5465b9e 100644 >> --- a/arch/arm/boot/dts/phy3250.dts >> +++ b/arch/arm/boot/dts/phy3250.dts >> @@ -45,6 +45,15 @@ >> enable-active-high; >> regulator-boot-on; >> }; >> + >> + sd_reg: fixed-regulator@2 { > > Please just "regulator@2", to comply with the ePAPR standard. thanks for review, just for my information, do I understand correctly that you reference to "Generic Names Recommendation" ? I have no objection to generalize device tree node name as you suggested, will do it. With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html