Hi Shawn, On 12/21/15 08:36, Shawn Guo wrote: > On Wed, Dec 16, 2015 at 04:01:08PM +0200, Igor Grinberg wrote: >> Hi Shawn, >> >> On 12/14/15 04:43, Shawn Guo wrote: >>> On Thu, Dec 10, 2015 at 04:01:37PM +0200, Igor Grinberg wrote: >>>> From: Ilya Ledvich <ilya@xxxxxxxxxxxxxx> >> >> [...] >> >>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt >>>> index 34c88b0..30b0ba1 100644 >>>> --- a/Documentation/devicetree/bindings/arm/fsl.txt >>>> +++ b/Documentation/devicetree/bindings/arm/fsl.txt >>>> @@ -53,6 +53,10 @@ i.MX6 Quad SABRE Automotive Board >>>> Required root node properties: >>>> - compatible = "fsl,imx6q-sabreauto", "fsl,imx6q"; >>>> >>>> +i.MX7D CL-SOM-iMX7 Board >>>> +Required root node properties: >>>> + - compatible = "compulab,cl-som-imx7", "fsl,imx7d"; >>>> + >>> >>> This is not a board produced by FSL, so it should be documented in >>> fsl.txt. >> >> You mean _should not_ be documented in fsl.txt, right? > > Right. Sorry. > >> Ok, I have no problem with that, we've just used the same approach OMAP >> takes - all the OMAP based boards are documented in the same file: >> Documentation/devicetree/bindings/arm/omap/omap.txt > > omap.txt is probably fine, as it's not ti.txt. Have you considered creating a kind of imx.txt? > >> >> Do you think we should document it in: >> Documentation/devicetree/bindings/arm/compulab-boards.txt >> (this file should already exist in arm-soc/next/dt)? > > Yeah, if the file already exist, it's the best option. But, as it > doesn't exist on my tree, I can not apply this change. It is already in linux-next. Who do you think should apply the v2 patch then? May be the arm-soc guys? (Cc'ed Olof and Arnd) > >> >>> >>>> Generic i.MX boards >>>> ------------------- >>>> >>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>>> index 30bbc37..83ed521 100644 >>>> --- a/arch/arm/boot/dts/Makefile >>>> +++ b/arch/arm/boot/dts/Makefile >>>> @@ -350,6 +350,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \ >>>> dtb-$(CONFIG_SOC_IMX6UL) += \ >>>> imx6ul-14x14-evk.dtb >>>> dtb-$(CONFIG_SOC_IMX7D) += \ >>>> + imx7d-cl-som-imx7.dtb \ >>>> imx7d-sdb.dtb >>>> dtb-$(CONFIG_SOC_LS1021A) += \ >>>> ls1021a-qds.dtb \ >>>> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts >>>> new file mode 100644 >>>> index 0000000..ba05198 >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts >>>> @@ -0,0 +1,150 @@ >>>> +/* >>>> + * Support for CompuLab CL-SOM-iMX7 System-on-Module >>>> + * >>>> + * Copyright (C) 2015 CompuLab Ltd. - http://www.compulab.co.il/ >>>> + * Author: Ilya Ledvich <ilya@xxxxxxxxxxxxxx> >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify it >>>> + * under the terms of the GNU General Public License version 2 as published by >>>> + * the Free Software Foundation. >>>> + */ >>> >>> GPL/X11 dual licence is generally suggested for newly added dts files, >>> as it will let non-Linux OS use them. >> >> I don't remember we've used this one before... >> Can you please point to an example? > > The following command will give you a plenty of examples. > > $ git grep X11 arch/arm/boot/dts 10x! -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
