Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Dec 15, 2015 at 7:41 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
>> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >index a14c0bb561d5..c55cf77006d0 100644
>> >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
>> >
>> >  Required properties:
>> >    - compatible: Must contain one of the following:
>>
>>    Really?
>
> Would "...one or more of the following" help?

+1

>> >+
>> >     - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>> >     - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>> >     - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>> >     - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>> >+    - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
>> >+    - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
>> >+
>> >+    When compatible with the generic version, nodes must list the
>> >+    SoC-specific version corresponding to the platform first followed
>> >+    by the generic version.
>> >+
>>
>>    This kinda contradicts the above claim.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux