On Mon, 2015-12-14 at 20:01 -0600, Hu Mingkai-B21284 wrote: > > > -----Original Message----- > > From: Hu Mingkai-B21284 > > Sent: Monday, December 07, 2015 4:44 PM > > To: 'Rob Herring' > > Cc: arm@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Li Yang-Leo-R58472; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Lian Minghuan-B31939 > > Subject: RE: [PATCH v2] dts/ls2080a: Update PCIe compatible > > > > > > > > > -----Original Message----- > > > From: Rob Herring [mailto:robh@xxxxxxxxxx] > > > Sent: Saturday, December 05, 2015 12:23 AM > > > To: Hu Mingkai-B21284 > > > Cc: arm@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Li Yang-Leo-R58472; > > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Lian Minghuan-B31939 > > > Subject: Re: [PATCH v2] dts/ls2080a: Update PCIe compatible > > > > > > On Fri, Dec 04, 2015 at 06:20:17PM +0800, Mingkai Hu wrote: > > > > From: Minghuan Lian <Minghuan.Lian@xxxxxxxxxxxxx> > > > > > > > > The patch adds LS2085a to PCIe compatible to fix the compatibility > > > > issue when using firmware with LS2085a compatible property. > > > > > > > > Signed-off-by: Minghuan Lian <Minghuan.Lian@xxxxxxxxxxxxx> > > > > Signed-off-by: Mingkai Hu <Mingkai.Hu@xxxxxxxxxxxxx> > > > > --- > > > > v2 change: > > > > - Rebased to latest kernel base > > > > > > How about implementing my comments on v1, too? > > > > > > > Hi Rob, > > > > Do you mean to change the combinations in layerscape-pci.txt as follows? > > > > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > > @@ -15,6 +15,7 @@ Required properties: > > > - compatible: should contain the platform identifier such as: > > > "fsl,ls1021a-pcie", "snps,dw-pcie" > > > - "fsl,ls2080a-pcie", "snps,dw-pcie" > > > + "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie" > > > > > > And the ls2085a was released first, but the dts file is for ls2080a (fsl- > > ls2080a.dtsi), So I prefer to put the ls2080a as the first compatible > > string. How about your suggestion? > > > > Hi Rob, > > I will keep the "fsl,ls2085a-pcie" as the first compatible string as > discussed. Do you mean "fsl,ls2080a-pcie"? -Scott > And change the layerscape-pci.txt as follows: > > > > - "fsl,ls2080a-pcie", "snps,dw-pcie" > > > + "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie" > > What's your suggestion? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
