On Mon, Dec 14, 2015 at 11:36 AM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Hello. > > On 12/14/2015 04:24 AM, Rob Herring wrote: > >>> Maxim Integrated MAX3355E chip integrates a charge pump and comparators >>> to >>> enable a system with an integrated USB OTG dual-role transceiver to >>> function >>> as an USB OTG dual-role device. In addition to sensing/controlling >>> Vbus, >>> the chip also passes thru the ID signal from the USB OTG connector. >>> On some Renesas boards, this signal is just fed into the SoC thru a >>> GPIO >>> pin -- there's no real OTG controller, only host and gadget USB >>> controllers >>> sharing the same USB bus; however, we'd like to allow host or gadget >>> drivers >>> to be loaded depending on the cable type, hence the need for the MAX3355 >>> extcon driver. The Vbus status signals are also wired to GPIOs (however, >>> we >>> aren't currently interested in them), the OFFVBUS# signal is controlled >>> by >>> the host controllers, there's also the SHDN# signal wired to a GPIO, it >>> should be driven high for the normal operation. >> >> >> As multiple people have said, fix the spacing here. > > > You are the first to complain abou _this_ patch. If you don't have other > issues with this driver in which case you should have trimmed the reply at > this point), I'd like to keep my spacing as is. Thank you. Your previous version was not "extcon-usb-gpio: add enable pin support"[1] which has now been re-written to be max3355 specific? "So what" and "I'd like to keep my spacing as is" aren't valid reasons. Fix it, then I'll look at the rest again. Rob [1] https://patchwork.ozlabs.org/patch/555378/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
