Hi Kalle, > -----Original Message----- > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Friday, December 11, 2015 2:04 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Nishant Sarmukadam; Xinming Hu; > devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] mwifiex: parse hscfg_gpio info from device tree > > + devicetree list > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > This patch reads hscfg_gpio from device tree and update internal > > variable > > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > > b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > > index e486867..d28a53f 100644 > > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > > @@ -1459,10 +1459,21 @@ int mwifiex_dnld_dt_cfgdata(struct > > mwifiex_private *priv, #ifdef CONFIG_OF > > struct property *prop; > > size_t len = strlen(prefix); > > + u32 data; > > int ret; > > > > /* look for all matching property names */ > > for_each_property_of_node(node, prop) { > > + if (!strncmp(prop->name, "marvell,hscfg_gpio", > > + strlen("marvell,hscfg_gpio"))) { > > + if (!of_property_read_u32(priv->adapter->dt_node, > > + prop->name, &data)) { > > + dev_dbg(priv->adapter->dev, > > + "hscfg gpio = 0x%x\n", data); > > + priv->adapter->hs_cfg.gpio = data; > > + } > > + } > > I don't see this documented in Documentation/devicetree/bindings. Please > create a binding document and review it with the device tree > maintainers. > > Actually when looking mwifiex close I see that it uses more undocumented > device tree interfaces: > > marvell_cfgdata > marvell,caldata > marvell,00_txpwrlimit > > I think these all should be properly documented and reviewed. But I'll > let the device tree people chime in what's the best way. > Thanks for the review. Sure. We will document existing DT interfaces and create updated version of this patch which includes documentation in bindings. Regards, Amit -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
