On Thursday 10 December 2015 16:59:14 xuejiancheng wrote: > On 2015/12/10 16:04, Arnd Bergmann wrote: > > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > >>> > >>> This is not what I meant. You have to use "syscon" as the most generic > >>> "compatible" value here, but should add a machine specific string > >>> as a more specific one. "hisilicon,sysctrl" is not appropriate because > >>> it does not identify the IP block uniquely, you can only use that > >>> in combination with another more specific string. > >> > >> OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value > >> for the sysctrl node in hi3519.dtsi. > >> > > > > Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl? > > > Is this not called a sysctrl at all in the datasheet then? > > It is OK to use hisilicon,hi3519-sysctrl. > > I thought syscon was more commonly used as abbr. of system-controller in the kernel code. > > "syscon" is the generic name for the framework in the kernel. This has nothing to do with how chip designers call their devices, and the DT should always match what the datasheet says, not what a random operating system calls things, even if it's the only OS you care about. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
