On Thu, Oct 31, 2013 at 10:15:26AM +0100, Denis Carikli wrote: > This is mostly cut and paste from the imx35 pinctrl driver. > The data was generated using sed and awk on > arch/arm/plat-mxc/include/mach/iomux-mx25.h. > > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > Cc: Pawel Moll <pawel.moll@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx> > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: Russell King <linux@xxxxxxxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Eric Bénard <eric@xxxxxxxxxx> > Signed-off-by: Denis Carikli <denis@xxxxxxxxxx> > --- > ChangeLog v8->v9: > - Whitespace cleanup betwen the CC: and Signed-off-by. > - Kconfig: rebased to make it apply on the new HEAD. > --- > .../bindings/pinctrl/fsl,imx25-pinctrl.txt | 33 ++ > arch/arm/boot/dts/imx25-pinfunc.h | 513 ++++++++++++++++++++ > arch/arm/boot/dts/imx25.dtsi | 1 + > arch/arm/mach-imx/Kconfig | 2 + > drivers/pinctrl/Kconfig | 8 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-imx25.c | 351 ++++++++++++++ > 7 files changed, 909 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt > create mode 100644 arch/arm/boot/dts/imx25-pinfunc.h > create mode 100644 drivers/pinctrl/pinctrl-imx25.c > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt > new file mode 100644 > index 0000000..64906ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt > @@ -0,0 +1,33 @@ > +* Freescale IMX25 IOMUX Controller > + > +Please refer to fsl,imx-pinctrl.txt in this directory for common binding part > +and usage. > + > +Required properties: > +- compatible: "fsl,imx25-iomuxc" > +- fsl,pins: two integers array, represents a group of pins mux and config > + setting. The format is fsl,pins = <PIN_FUNC_ID CONFIG>, PIN_FUNC_ID is a > + pin working on a specific function, CONFIG is the pad setting value like > + pull-up for this pin. Please refer to imx25 datasheet for the valid pad > + config settings. This description is wrong. We have a correct description of fsl,pins in Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt already, so we should probably refer to it instead of describing it again here. This is wrong in all Documentation/devicetree/bindings/pinctrl/fsl,imx?*-pinctrl.txt files in the tree currently. Otherwise: Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html