On Tue, Dec 08, 2015 at 06:05:51AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > Add fallback compatibility string.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> >
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > ---
> (snip)
> > + {
> > + .compatible = "renesas,usbhs",
> > + .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > + },
> > { },
> > };
>
> I think this is too much. This driver is used not only from R-Car Gen2.
> It will work as normal mode if .data was 0.
> see usbhs_parse_dt()
Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
