On 25/11/15 02:51, Guenter Roeck wrote: > On 11/24/2015 02:15 PM, Simon Arlott wrote: >> Return the remaining time from the hardware control register. >> >> Warn when the device is registered if the hardware watchdog is currently >> running and report the remaining time left. > > This is really two logical changes, isn't it ? If you insist then I'll split it out into yet another patch. > Nice trick to figure out if the watchdog is running. > > What is the impact ? Will this result in interrupts ? Yes, if it is running it will receive interrupts and check hw->running to determine if it should stop the watchdog or not. > If so, would it make sense to _not_ reset the system after a timeout > in this case, but to keep pinging the watchdog while the watchdog device > is not open ? As the whole point of a hardware watchdog is to reset the system when there is a problem with the software, it should not be automatically reset by the driver on startup. If the watchdog is already running then it needs to be pinged by userspace before the timeout. The bootloader (CFE) doesn't leave the watchdog running. On my system I prepend some code before vmlinuz that starts it running at the maximum timeout. A module parameter could be added to automatically ping/stop it if it's running, but this should be in the watchdog core and not an individual driver. -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
