> -----Original Message----- > From: Viresh Kumar [mailto:viresh.kumar@xxxxxxxxxx] > Sent: Tuesday, November 24, 2015 3:11 PM > To: Jia Hongtao-B38951 > Cc: edubezval@xxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linuxppc- > dev@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Wood Scott-B07421 > Subject: Re: [PATCH] cpufreq: qoriq: Register cooling device based on > device tree > > On 24-11-15, 14:55, Jia Hongtao wrote: > > + /* Register CPU cooling device for QorIQ platform */ > > + for_each_node_with_property(cpu_np, "#cooling-cells") { > > + of_property_read_u32(cpu_np, "reg", &cpu_id); > > + cpufreq_get_policy(&cpu_policy, cpu_id); > > That's not the right way to do it. You already have DT node for the CPU, > look at how it is done from ->ready() callback for cpufreq-dt. > > -- > viresh Thanks. I made a new patch to use ->ready callback for cpu cooling registration. I will send V2 after test. -Hongtao. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html