> +static netdev_features_t hns_nic_fix_features( > + struct net_device *netdev, netdev_features_t features) { > + struct hns_nic_priv *priv = netdev_priv(netdev); > + > + switch (priv->enet_ver) { > + case AE_VERSION_1: > + features &= ~(NETIF_F_TSO | NETIF_F_TSO6 | > + NETIF_F_HW_VLAN_CTAG_FILTER); > + break; > + default: > + break; > + } > + return features; > +} > + Isn't AE_VERSION_1 something fixed once you publish your features? If it can't be changed, why not simply remove the features from `hw_features' instead of having to implement this ndo? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html