On 20.11.2015 21:47, Rob Herring wrote:
> On Sat, Oct 17, 2015 at 4:35 PM, Vladimir Zapolskiy <vz@xxxxxxxxx> wrote:
>> NXP LPC32xx SoC has one USB OTG controller, which is supposed to work
>> with an external phy (default is NXP ISP1301).
>>
>> Practically the USB controller contains 5 subdevices:
>> - host controller 0x3102 0000 -- 0x3102 00FF
>> - OTG controller 0x3102 0100 -- 0x3102 01FF
>> - device controller 0x3102 0200 -- 0x3102 02FF
>> - I2C controller 0x3102 0300 -- 0x3102 03FF
>> - clock controller 0x3102 0F00 -- 0x3102 0FFF
>
> [...]
>
>> - /*
>> - * Enable either ohci or usbd (gadget)!
>> - */
>> - ohci: ohci@31020000 {
>> - compatible = "nxp,ohci-nxp", "usb-ohci";
>> - reg = <0x31020000 0x300>;
>> - interrupts = <0x3b 0>;
>> - status = "disabled";
>> - };
>> + usb {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "simple-bus";
>> + ranges = <0x0 0x31020000 0x00001000>;
>>
>> - usbd: usbd@31020000 {
>> - compatible = "nxp,lpc3220-udc";
>> - reg = <0x31020000 0x300>;
>> - interrupts = <0x3d 0>, <0x3e 0>, <0x3c 0>, <0x3a 0>;
>> - status = "disabled";
>> + /*
>> + * Enable either ohci or usbd (gadget)!
>> + */
>> + ohci: ohci@0 {
>> + compatible = "nxp,ohci-nxp", "usb-ohci";
>> + reg = <0x0 0x300>;
>> + interrupts = <0x3b 0>;
>> + status = "disabled";
>> + };
>> +
>> + usbd: usbd@0 {
>> + compatible = "nxp,lpc3220-udc";
>> + reg = <0x0 0x300>;
>
> Not a result of this change, but you are overlapping addresses. Please
> don't do that. It causes problems adding device resources into the
> resource tree (i.e. request_resource).
>
As you noticed this is legacy code, it will be corrected after fixing
USB host and device drivers, and this is in long term plans. USB changes
require at least CCF and IRQ chip changes applied.
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
