Rob Herring <robh@xxxxxxxxxx> writes: > On Thu, Nov 19, 2015 at 06:33:45PM +0000, Mans Rullgard wrote: >> This adds a binding for the secondary interrupt controller in >> Sigma Designs SMP86xx and SMP87xx chips. >> >> Signed-off-by: Mans Rullgard <mans@xxxxxxxxx> >> --- >> .../interrupt-controller/sigma,smp8642-intc.txt | 47 ++++++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt >> new file mode 100644 >> index 0000000..f82cddf >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt >> @@ -0,0 +1,47 @@ >> +Sigma Designs SMP86xx/SMP87xx secondary interrupt controller >> + >> +Required properties: >> +- compatible: should be "sigma,smp8642-intc" >> +- reg: physical address of MMIO region >> +- interrupt-parent: phandle of parent interrupt controller >> +- interrupt-controller: boolean >> + >> +One child node per control block with properties: >> +- sigma,reg-offset: offset of registers from main base address > > Your driver defines these offsets too. > > Do you expect to have many different variations here? If not, I would > get rid of all the child nodes and just hard code it in the driver. Then how will other DT nodes reference the correct one? -- Måns Rullgård mans@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
