On Thu, 19 Nov 2015 21:47:05 +0100
Sebastian Hesselbarth wrote:
> On 16.11.2015 12:09, Jisheng Zhang wrote:
> > The Marvell Berlin BG2Q has 3 watchdogs which are compatible with the
> > snps,dw-wdt driver sit in the sysmgr domain. This patch adds the
> > corresponding device tree nodes.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/berlin2q.dtsi | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> > index a3ecde5..fac4315 100644
> > --- a/arch/arm/boot/dts/berlin2q.dtsi
> > +++ b/arch/arm/boot/dts/berlin2q.dtsi
> > @@ -483,6 +483,30 @@
> > ranges = <0 0xfc0000 0x10000>;
> > interrupt-parent = <&sic>;
> >
> > + wdt0: watchdog@1000 {
> > + compatible = "snps,dw-wdt";
> > + reg = <0x1000 0x100>;
> > + clocks = <&refclk>;
> > + interrupts = <0>;
> > + status = "disabled";
>
> Jisheng,
>
> as the watchdogs are internal and cannot be clock gated
> at all, how about we remove the status = "disabled" and
> make them always available?
there are two issues here:
1. the dw-wdt can't support multiple variants now. I have rewrite the driver
with watchdog core supplied framework, but the patch isn't sent out and
may be need time to clean up and review.
2. not all dw-wdt devices are available and functional. This depends on
board design and configuration.
So IMHO status=disabled and patch5-8 is necessary, what do you think?
Thanks a lot for review,
Jisheng
>
> I have applied patches 1-4 with the status property removed.
> This also renders patches 5-8 useless.
>
> So, for now tentatively
>
> Appled to berlin/dt and berlin64/dt respectivly
>
> with status property removed.
>
> Sebastian
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
